Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions specs/Modal.events.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,37 @@ export default () => {
requestCloseCallback.called.should.not.be.ok();
});
});

it("closes on first overlay click after content click stops propagation", () => {
const requestCloseCallback = sinon.spy();
let innerButton = null;
const setInnerButton = ref => {
innerButton = ref;
};
const stopPropagation = event => event.stopPropagation();

const props = {
isOpen: true,
shouldCloseOnOverlayClick: true,
onRequestClose: requestCloseCallback
};

withModal(
props,
<button ref={setInnerButton} onClick={stopPropagation} />,
modal => {
mouseDownAt(innerButton);
mouseUpAt(innerButton);
clickAt(innerButton);

mouseDownAt(moverlay(modal));
mouseUpAt(moverlay(modal));
clickAt(moverlay(modal));

requestCloseCallback.calledOnce.should.be.ok();
}
);
});
});

it("should not stop event propagation", () => {
Expand Down
8 changes: 8 additions & 0 deletions src/components/ModalPortal.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export default class ModalPortal extends Component {

this.shouldClose = null;
this.moveFromContentToOverlay = null;
this.preventOverlayMouseDown = false;
}

componentDidMount() {
Expand Down Expand Up @@ -322,6 +323,12 @@ export default class ModalPortal extends Component {
if (!this.props.shouldCloseOnOverlayClick && event.target == this.overlay) {
event.preventDefault();
}

if (this.preventOverlayMouseDown) {
this.preventOverlayMouseDown = false;
} else if (event.target == this.overlay) {
this.shouldClose = null;
}
};

handleContentOnClick = () => {
Expand All @@ -330,6 +337,7 @@ export default class ModalPortal extends Component {

handleContentOnMouseDown = () => {
this.shouldClose = false;
this.preventOverlayMouseDown = true;
};

requestClose = event =>
Expand Down