Skip to content

Fix download modal unreachable after LiveCD removal - #145

Closed
HBelusca with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-code-for-review-comment
Closed

Fix download modal unreachable after LiveCD removal#145
HBelusca with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-code-for-review-comment

Conversation

Copilot AI commented Jul 30, 2026

Copy link
Copy Markdown

After removing the #livecd/.modalbtn element from download.html, the JS click handler bound to .modalbtn became a no-op, and stripping href from #bootcd broke the link entirely (no navigation, no keyboard focus).

Changes

  • static/js/download.js: Bind handler directly to #bootcd; retain its href as a no-JS fallback; call e.preventDefault() to intercept and show the modal when JS is active.
// Before (broken: .modalbtn no longer exists; href stripped)
var bootcd = $("#bootcd").attr("href");
$("#bootcd").removeAttr("href");
$(".modalbtn").click(function(e){  });

// After
var bootcd = $("#bootcd").attr("href");
$("#bootcd").click(function(e){
  e.preventDefault();
  $("#bootcdModal").modal("toggle");
  $('.modal-footer a').attr("href", bootcd);
});

Copilot AI changed the title [WIP] Fix code for review comment on pull request 138 Fix download modal unreachable after LiveCD removal Jul 30, 2026
Copilot AI requested a review from HBelusca July 30, 2026 16:59
@HBelusca HBelusca closed this Jul 30, 2026
@HBelusca
HBelusca deleted the copilot/fix-code-for-review-comment branch July 30, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants