Skip to content

allow private in with constraints #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aspeddro merged 1 commit into from
Jul 12, 2026
Merged

allow private in with constraints #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion grammar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,7 +1240,7 @@ export default grammar({
$.module_primary_expression,
),

constrain_type: ($) => seq("type", $._type, choice("=", ":="), $._type),
constrain_type: ($) => seq("type", $._type, choice("=", ":="), optional("private"), $._type),

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict private to = constraints

Because optional("private") is placed after choice("=", ":="), this also accepts destructive substitutions like S with type t := private int. The := form takes a plain replacement type and should not carry the privacy marker that belongs to equality constraints such as with type t = private ..., so tree-sitter consumers now treat compiler-invalid signatures as valid. Split the alternatives so private is only allowed on the = branch.

Useful? React with 👍 / 👎.


functor_use: ($) =>
seq($.module_primary_expression, alias($.functor_arguments, $.arguments)),
Expand Down
12 changes: 12 additions & 0 deletions src/grammar.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading