Skip to content

fix(rspack): skip next example test in ecosystem ci#484

Merged
intellild merged 2 commits into
mainfrom
fix/ecosystem-ci
Jul 22, 2026
Merged

fix(rspack): skip next example test in ecosystem ci#484
intellild merged 2 commits into
mainfrom
fix/ecosystem-ci

Conversation

@intellild

Copy link
Copy Markdown
Contributor

No description provided.

@intellild

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5cf18d71aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json Outdated
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The CI workflow now runs the standard build script instead of build:ci. The Rspack build and test scripts are renamed from their :ci variants to :eco-ci, while retaining their existing workspace filters and commands.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so its relevance to the changeset cannot be assessed. Add a short description summarizing the CI script rename and the skipped Next example test.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: skipping the Next example test in ecosystem CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ecosystem-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yaml:
- Line 38: Restore the CI workflow command to invoke the existing build:ci
script instead of the unfiltered build script. Update the run step containing
node --run build, preserving the CI exclusions for rspack/next-rspack-app-router
and rspack/next-rspack-page-router.

In `@package.json`:
- Line 24: Update the root test execution path, including the `test` script or
its CI invocation, to call `test:rspack:ci` instead of `test:rspack` so the
CI-only package exclusions are applied; preserve the existing `test:rstest`
step.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a250398a-4ae8-4525-b8f6-c82d05d92c55

📥 Commits

Reviewing files that changed from the base of the PR and between ffbb4fd and 5cf18d7.

📒 Files selected for processing (2)
  • .github/workflows/ci.yaml
  • package.json

Comment thread .github/workflows/ci.yaml
Comment thread package.json Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Line 14: Update package.json lines 14-14 and 24-24: change build:ci to invoke
build:rspack:eco-ci and the ecosystem CI test path to invoke test:rspack:eco-ci,
ensuring both callers reference the renamed filtered scripts.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e01ba25-a5d2-43d3-9f11-999597eea3c0

📥 Commits

Reviewing files that changed from the base of the PR and between 5cf18d7 and 3ce4fbc.

📒 Files selected for processing (1)
  • package.json

Comment thread package.json
@intellild
intellild merged commit 87c1385 into main Jul 22, 2026
4 checks passed
@intellild
intellild deleted the fix/ecosystem-ci branch July 22, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant