fix(rspack): skip next example test in ecosystem ci#484
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cf18d71aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📝 WalkthroughWalkthroughThe CI workflow now runs the standard 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Line 38: Restore the CI workflow command to invoke the existing build:ci
script instead of the unfiltered build script. Update the run step containing
node --run build, preserving the CI exclusions for rspack/next-rspack-app-router
and rspack/next-rspack-page-router.
In `@package.json`:
- Line 24: Update the root test execution path, including the `test` script or
its CI invocation, to call `test:rspack:ci` instead of `test:rspack` so the
CI-only package exclusions are applied; preserve the existing `test:rstest`
step.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a250398a-4ae8-4525-b8f6-c82d05d92c55
📒 Files selected for processing (2)
.github/workflows/ci.yamlpackage.json
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 14: Update package.json lines 14-14 and 24-24: change build:ci to invoke
build:rspack:eco-ci and the ecosystem CI test path to invoke test:rspack:eco-ci,
ensuring both callers reference the renamed filtered scripts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
No description provided.