Use short_description in confirmation email; stop the rich-description fallback#2013
Draft
maebeale wants to merge 3 commits into
Draft
Use short_description in confirmation email; stop the rich-description fallback#2013maebeale wants to merge 3 commits into
maebeale wants to merge 3 commits into
Conversation
…n leak #2012 removed the rich rhino_description dump from the HTML part of the registration confirmation email but left it in the text part, where it still flattened embedded images to "[filename.jpg]" alt text and reproduced the whole event body. Remove that leak, and render the admin-authored plain-text short_description (already used for calendar invites) in both parts instead — a short blurb that can't carry images, with no fallback to the rich description. Update the form hint to note the field now feeds confirmation emails too. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
short_description now solely drives the calendar-entry blurb; when it's blank the entry carries no description rather than a flattened version of the rich show-page body (which can't render in a calendar and may embed images). Aligns calendar behavior with the confirmation email and drops the now-inaccurate fallback note from the form hint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small mailer + decorator change, contained behavior swap
Follow-up to #2012, which removed the rich
rhino_descriptiondump from the confirmation email's HTML part but left it in the text part.Why
rhino_description.to_plain_text, which flattens embedded images to[filename.jpg]alt text and reproduces the whole event body.What
short_descriptionin both email parts instead — no fallback to the rich description; blank → omitted.EventDecorator#calendar_links) likewise stop falling back torhino_descriptionwhenshort_descriptionis blank; the entry just carries no blurb.short_descriptionfeeds both calendar links and confirmation emails.Reuses the existing
short_descriptioncolumn (added in #1876) — no schema change.