feat: Incorporate optional and nullable properties into generated types#931
Merged
Merged
Conversation
Update to @seamapi/blueprint@0.60.0, which adds isOptional and isNullable properties to the blueprint, and update the codegen to generate types that accurately reflect optionality and nullability: - Compute isOptionalParamsOk from the blueprint request parameters instead of falling back to true. Endpoint methods now require the parameters argument when an endpoint has required parameters. - Generate response types directly from RouteResponse instead of wrapping in SetNonNullable<Required<...>>, which stripped the optional and nullable markers from response keys that are genuinely optional or nullable (e.g., /events/get may return either event or message). Remove the now-unused SetNonNullable helper type. - Update to @seamapi/types@1.974.0 and regenerate all routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ymgiD6xCZXPhepJy9Fprz
razor-x
marked this pull request as ready for review
July 24, 2026 15:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_013ymgiD6xCZXPhepJy9Fprz