Fix/empty container dataset - #38
Merged
Merged
Conversation
PreciousOritsedere
requested review from
langsamu and
matthieubosquet
as code owners
July 27, 2026 11:23
jeswr
approved these changes
Jul 27, 2026
|
|
||
| get container(): Container | undefined { | ||
| // Return the first container in the dataset | ||
| // Non-empty containers advertise children via ldp:contains. |
| return s | ||
| } | ||
|
|
||
| // Empty containers have no ldp:contains; resolving via rdf:type instead. |
Member
There was a problem hiding this comment.
Suggested change
| // Empty containers have no ldp:contains; resolving via rdf:type instead. | |
| // If the container is empty, then the only instance of `ldp:Container` | |
| // and `ldp:BasicContainer` in this dataset should be the container | |
| // itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Empty folders failed because we only looked for containers via
ldp:contains.Related to solid-file-manager #61 and PR #64 review.
I am implementing the fix here, to allow me use this package in the solid file manager