mcmc_pairs: ensure all divergences/treedepth hits plotted correctly i…#556
Merged
Conversation
…n all panels fixes #555
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
=======================================
Coverage 98.79% 98.80%
=======================================
Files 35 35
Lines 6583 6585 +2
=======================================
+ Hits 6504 6506 +2
Misses 79 79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
The failure on windows is unrelated and due to the latest RcppParallel release (CRAN needs to rebuild rstanarm's windows binary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #555
Ensure that divergences and max treedepth hits are plotted correctly in all
mcmc_pairspanels. There was a bug introduced when switching fromaes_toaesdue to lazy evaluation. In certain cases every panel drew the last panel's divergence mask.