Typing NDCube#950
Open
samaloney wants to merge 18 commits into
Open
Conversation
* Potential bug referencing self.table_coords v self._table_coords
* Fix a potential but where with nan operation on data with no nans
* Remove assert in import code paths
* Possibl bug and missing methods on ABC
samaloney
force-pushed
the
feature-typing
branch
from
July 23, 2026 15:13
e1808f4 to
4d1a861
Compare
Member
Author
|
Not sure how to resolve the doc build issue I think its because there is more then one |
| def __str__(self) -> str: | ||
| classname = self.__class__.__name__ | ||
| elements = [f"{', '.join(table.names)} ({axes}) {table.physical_types}: {table}" | ||
| elements = [f"{', '.join(table.names or ())} ({axes}) {table.physical_types}: {table}" |
Member
There was a problem hiding this comment.
Suggested change
| elements = [f"{', '.join(table.names or ())} ({axes}) {table.physical_types}: {table}" | |
| elements = [f"{', '.join(table.names) if table.names else ()} ({axes}) {table.physical_types}: {table}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Add types and type checking to NDCube
QuantityLikeAI Assistance Disclosure
AI tools were used for: