chore: remove nixConfig from flake.nix#2308
Open
brainrake wants to merge 2 commits into
Open
Conversation
The extra-substituters entry only applies to trusted users, so everyone else gets a misleading "ignoring untrusted substituter, you are not a trusted user" warning that invites adding themselves to trusted-users -- a local privilege-escalation vector, not a config gap to fix.
PostgreSQL Extension Dependency Analysis: PR #2308
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2308
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
brainrake
enabled auto-merge
July 23, 2026 12:30
mmlb
reviewed
Jul 23, 2026
Comment on lines
-4
to
-5
| # Skip rebuilding all the packages, download instead. | ||
| # See nix/docs/binary-cache.nix to set it up. |
Collaborator
There was a problem hiding this comment.
Might be good to keep the comment, it makes sense to have the doc pointer here since its pretty likely to have someone read the flake at some point.
Maybe we do:
Suggested change
| # Skip rebuilding all the packages, download instead. | |
| # See nix/docs/binary-cache.nix to set it up. | |
| # Skip rebuilding all the packages, download instead. | |
| # See nix/docs/binary-cache.nix to set it up. | |
| # nixConfig.extra-substituters = [ "https://nix-postgres-artifacts.s3.amazonaws.com" ]; | |
| # nixConfig.extra-trusted-public-keys = [ "nix-postgres-artifacts:dGZlQOvKcNEjvT7QEAJbcV6b6uk7VF/hWMjhYleiaLI=" ]; |
mmlb
approved these changes
Jul 23, 2026
mmlb
left a comment
mmlb
left a comment
Collaborator
There was a problem hiding this comment.
Just a quick comment, will approve either way as this is definitely a better setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
nixConfig.extra-substitutersonly applies to trusted users, so everyone else sees:That warning invites people to add themselves to
trusted-users, which is actually a local privilege-escalation vector (Nix manual, see also SEC-894), not a config gap to fix.What
Remove
nixConfigfromflake.nix. (Configure substituters vianix.conf/nix-darwin instead.)