fix(supermemory): honor options.limit in search() instead of hardcoding 30 - #56
Open
dkoosis wants to merge 1 commit into
Open
fix(supermemory): honor options.limit in search() instead of hardcoding 30#56dkoosis wants to merge 1 commit into
dkoosis wants to merge 1 commit into
Conversation
…ng 30 search() hardcoded limit: 30, silently overriding whatever limit the caller passed in SearchOptions — so a benchmark requesting a deeper retrieval pool (e.g. limit 50) still capped at 30. Honor options.limit, keeping 30 as the default. Flagged by @sohamd22 in PR supermemoryai#44 review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SupermemoryProvider.search()hardcodeslimit: 30, silently overriding whateverlimitthe caller passes inSearchOptions— a consumer requesting a deeper retrieval pool still caps at 30.Fix
Honor
options.limit, keeping30as the default:SearchOptions.limitalready exists insrc/types/provider.ts, so no type changes, and callers that don't passlimitsee identical behavior. Typechecks clean.Flagged by @sohamd22 in #44 review. #57 is stacked on this branch.