fix: update DataStore for 16 KB compatibility - #1107
Conversation
This comment has been minimized.
This comment has been minimized.
c0eb7ec to
f9b61c1
Compare
|
@coreyphillips Thanks — your review identified the problem. The verification script and 49k-line vendored rewrite were an overengineered, bad AI attempt. I removed them completely. This PR now contains only the DataStore 1.2.0 → 1.2.1 update and its changelog fragment: 2 insertions and 1 deletion. The original Android 17 alert named I then built Bundled ML Kit remains unchanged. The scanner code, native verification scripts, symbol packaging, and Could you re-review the reduced head f9b61c149? |
f9b61c1 to
ad4f97e
Compare
jvsena42
left a comment
There was a problem hiding this comment.
tested on Pixel 9 Android 17 / API 37, PAGE_SIZE=16384 (16 KB pages) emulator
Fixes #1103
This PR:
libdatastore_shared_counter.souses 16 KB-alignedGNU_RELROpadding.PAGE_SIZE=16384; the captured runtime result reportspageSizeCompat=0.QA Notes
Manual Tests
mainnetDebugon the Android 17Pixel_10_Pro_XLemulator with a 16 KB page size → Confirm the Android compatibility alert is absent andpageSizeCompat=0.Automated Checks
just compilejust testjust lintjust changelog next:app:assembleMainnetDebug --refresh-dependencieswith Maven Local excludedgit diff --check