fix: allow terminal profile deletion

[ben-kaufman]

Follow-up to #1097.

Companion iOS fix: synonymdev/bitkit-ios#640

Description

This PR allows terminal Pubky profile deletion to continue when private Paykit endpoint cleanup cannot finish, such as when a contact is offline or a private link is still being established.

• Still attempts private endpoint revocation before deleting the profile.
• Keeps the remote Pubky deletion authoritative, so a homeserver or connectivity failure still shows the existing retry/disconnect dialog.
• Clears local Paykit state after the Pubky profile is deleted.
• Warns that contacts may retain profile and payment information shared with them previously.

Paykit lifecycle/concurrency hardening and E2E repository changes remain outside this PR.

Preview

N/A — behavior and confirmation-copy update only.

QA Notes

Manual Tests

• 1. Profile → Edit Profile → Delete Profile with an offline or still-linking contact → confirm: Pubky deletion proceeds instead of being blocked by private cleanup.
• 2. Profile → Edit Profile → Delete Profile while the Pubky homeserver is unavailable → confirm: Unable to Delete Profile still offers retry or disconnect.
• 3. Profile → Edit Profile → Delete Profile: confirmation explains that contacts may retain previously shared profile and payment information.

Automated Checks

• EditProfileViewModelTest.kt: verifies private cleanup failure does not block a successful Pubky deletion and local Paykit cleanup.
• ./gradlew compileDevDebugKotlin passed.
• ./gradlew testDevDebugUnitTest passed.
• ./gradlew detekt passed with pre-existing findings outside this change.
• git diff --check passed.

[greptile-apps]

Greptile Summary

Profile deletion now proceeds when private Paykit endpoint cleanup fails.

• Attempts private endpoint cleanup before deleting the remote Pubky profile.
• Clears local Paykit state after successful profile deletion.
• Updates deletion confirmation copy and unit-test expectations.
• Adds a changelog entry for the corrected deletion behavior.

Confidence Score: 5/5

The PR appears safe to merge because no eligible blocking failure remains in this follow-up review.

No blocking failure remains.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt	Makes private Paykit cleanup best-effort while preserving remote Pubky deletion as the authoritative success condition.
app/src/main/res/values/strings.xml	Updates the confirmation message to warn that contacts may retain previously shared information.
app/src/test/java/to/bitkit/ui/screens/profile/EditProfileViewModelTest.kt	Verifies that failed private cleanup no longer blocks Pubky deletion, local cleanup, or the success effect.
changelog.d/next/1108.fixed.md	Documents that private Paykit cleanup failures no longer block profile deletion.

Sequence Diagram

sequenceDiagram
    actor User
    participant VM as EditProfileViewModel
    participant Paykit as PrivatePaykitRepo
    participant Pubky as PubkyRepo
    User->>VM: Confirm profile deletion
    VM->>Paykit: removePublishedEndpointsForCleanup()
    Note over VM,Paykit: Cleanup failure does not stop deletion
    VM->>Pubky: deleteProfileWithSessionRetry()
    alt Pubky deletion succeeds
        VM->>Paykit: closeAndClear()
        VM-->>User: DeleteSuccess
    else Pubky deletion fails
        VM-->>User: Show retry/disconnect dialog
    end

Loading

_{Reviews (2): Last reviewed commit: "chore: rename changelog fragment" | Re-trigger Greptile}

[piotr-iohk]

tACK

[ovitrif]

utAck