Skip to content

Add type_hint to TransferTypeConverter.from_transfer_type - #1685

Merged
tconley1428 merged 3 commits into
mainfrom
amazzeo/transfer-type-type-hint
Jul 27, 2026
Merged

Add type_hint to TransferTypeConverter.from_transfer_type#1685
tconley1428 merged 3 commits into
mainfrom
amazzeo/transfer-type-type-hint

Conversation

@VegetarianOrc

@VegetarianOrc VegetarianOrc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

What was changed

Add type_hint to TransferTypeConverter.from_transfer_type to allow inspection of type args during conversion.

Why?

Without this, generic value types are unable to discern the concrete types of their generic type args.

Checklist

  1. How was this tested:
  • existing tests
  • added a parameterized test using the same generic type with two different type args.

@VegetarianOrc
VegetarianOrc requested a review from a team as a code owner July 27, 2026 21:25
@tconley1428
tconley1428 merged commit 5df7192 into main Jul 27, 2026
29 of 31 checks passed
@tconley1428
tconley1428 deleted the amazzeo/transfer-type-type-hint branch July 27, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants