chore: remove Linear ticket references so the repo is self-contained - #157
Merged
Conversation
Strips ~150 JEF-#### comment/doc tags across server, ui, docs, and CI scripts so the codebase only references in-repo material. Where a ticket documented a decision captured in an ADR, the reference is replaced with the ADR number (e.g. JEF-580 -> ADR 0021, JEF-473/493 -> ADR 0013/0019); bare trailing tags with no further in-repo context are just deleted. server/migrations/*.sql is deliberately untouched -- those files are checksum-locked by sqlx::migrate! and editing even a comment byte would crashloop the pod on boot. No behavior change: only comments, docstrings, and doc files were edited. Runtime string literals (e.g. test table names like jef_590_lock_test) and the online-DDL advisory-lock constant (0x004A_4546_5F35_3830) are untouched byte-for-byte -- only its comment was reworded to drop the ticket reference. Tests: existing server (cargo test --locked, 78+67 passed) and UI (vitest, 33 passed) suites cover all touched files; no new tests needed since this is a pure prose/comment cleanup. Verified cargo fmt/check/clippy --all-targets -D warnings and npm run lint/build all green. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JEF-####comment/doc references and their linear.app associations across server, ui, docs, and CI scripts so the codebase only references in-repo material (ADRs, PRs, code) rather than an external tracker.JEF-580->ADR 0021,JEF-473/JEF-493->ADR 0013/ADR 0019,JEF-425->ADR 0014,JEF-452->ADR 0016,JEF-462->ADR 0017,JEF-471->ADR 0018). Bare trailing tags with no further in-repo context are simply deleted, with surrounding punctuation/wording adjusted so the sentence still reads cleanly.server/migrations/*.sqlis deliberately untouched — those files are checksum-locked bysqlx::migrate!; editing even a comment byte would change the checksum and crashloop the pod on boot (the exact incident this codebase recently fixed).server/migrations/README.md(not checksummed) was updated.online_ddl::ADVISORY_LOCK_KEYconstant (0x004A_4546_5F35_3830, which happens to spell "JEF_580" in ASCII) is unchanged byte-for-byte — only its comment was reworded to describe it as a fixed constant distinct from sqlx's DB-name-hash migrate lock, without citing the ticket.No behavior change: only comments, docstrings, and
.mdfiles were edited. No identifiers, test names, runtime string literals (e.g. test table names likejef_590_lock_test,jef580_*_test), API paths, or config values were touched.Closes JEF-596
Test plan
grep -rInE "JEF-[0-9]|linear\.app" --exclude-dir=target --exclude-dir=node_modules --exclude-dir=.git .returns matches only inserver/migrations/*.sqlgit diff --name-only(vs main) shows noserver/migrations/*.sqlfilescd server && cargo fmt --check && cargo check && cargo clippy --all-targets -- -D warnings && cargo test --locked— all green (78 unit + 67 smoke tests pass)cd ui && npm ci && npm run lint && npm run build && npx vitest run— all green (33 tests pass)/soundcheck:pr-reviewself-check — no Critical/High findings (pure comment/doc diff, no logic changed)🤖 Generated with Claude Code
https://claude.ai/code/session_01JbrmfzHsTMMzPaSrUkZgWo