Skip to content

Pin @types/react and @types/react-dom to 18.x #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deepshekhardas wants to merge 1 commit into from
Closed

Pin @types/react and @types/react-dom to 18.x #4461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@
"overrides": {
"typescript": "5.5.4",
"@types/node": "22.20.0",
"@types/react": "18.2.69",
"@types/react-dom": "18.2.7",
Comment on lines +97 to +98

@devin-ai-integration devin-ai-integration Bot Aug 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Dependency lock file wasn't refreshed, so installs and every CI job fail

New pinned type-package versions were added to the dependency overrides (@types/react/@types/react-dom at package.json:97-98) without regenerating the lock file, so strict installs abort because the recorded overrides no longer match.
Impact: Every CI workflow and any fresh install fails immediately at the install step until the lock file is regenerated.

Lock file overrides block is out of sync with package.json

pnpm-lock.yaml:7-49 lists the overrides map and does not contain @types/react or @types/react-dom. pnpm validates this block against the root package.json when running with --frozen-lockfile, which every workflow uses (e.g. .github/workflows/typecheck.yml:32, .github/workflows/code-quality.yml:32, .github/workflows/unit-tests-webapp.yml:106). The fix is to run pnpm i at the repo root and commit the resulting pnpm-lock.yaml, as described in AGENTS.md's dependency-installation guidance.

Prompt for agents 
The root package.json now declares two new pnpm overrides (@types/react 18.2.69 and @types/react-dom 18.2.7) but pnpm-lock.yaml's overrides section was not regenerated, so `pnpm install --frozen-lockfile` (used by all GitHub workflows) will fail with an ERR_PNPM_OUTDATED_LOCKFILE-style error. Run `pnpm i` from the repo root and commit the updated pnpm-lock.yaml along with the package.json change.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +97 to +98

@devin-ai-integration devin-ai-integration Bot Aug 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Unconditional override contradicts trigger-sdk's declared @types/react ^19 dev dependency

The new overrides are unscoped (unlike the neighbouring react@^18 / react-dom@^18 selectors), so every workspace gets React 18 typings regardless of what it declares. packages/trigger-sdk/package.json:94 declares @types/react: ^19.2.14 and packages/rsc/package.json pins react/react-dom to 19.0.0-rc.1 with @types/react: "*". I checked the sources: packages/trigger-sdk/src/v3/chat-react.ts only uses useCallback/useEffect/useRef/useState, packages/react-hooks/src only uses classic hooks, and packages/rsc/src never imports React types, so nothing currently requires React 19-only typings and the override should be safe today. Still, the SDK's declared range is now silently unsatisfied — consider aligning that dev dependency to 18.x or scoping the override (e.g. @types/react@^18) so future React 19 type usage in those packages isn't type-checked against the wrong typings.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"react@^18": "18.3.1",
"react-dom@^18": "18.3.1",
"ai@^6": "6.0.116",
Expand Down