feat(web-shared): Alt+hover span measurement in the new trace viewer#2985
Open
mitul-s wants to merge 2 commits into
Open
feat(web-shared): Alt+hover span measurement in the new trace viewer#2985mitul-s wants to merge 2 commits into
mitul-s wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 5e8c292 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figma-style measurement in the new trace viewer: with a span selected, hold Alt and hover any other row to see the time delta between the two spans, drawn as a single measurement line.
CleanShot.2026-07-17.at.11.26.19.mp4
How it works
DeltaIndicatoris deleted; both modes render through oneDeltaMeasureLinecomponent).Implementation
computeSpanDelta()inutils.tsnext tocomputeSpanGaps, unit-tested (disjoint both directions, overlap, containment, identical starts, zero-duration, clamping, off-screen).clientYin the existing timeline mousemove handler (now a singleTimelineHover {fraction, rowIndex}state) — no per-row listeners,TimelineBarmemoization untouched.Replaces #2976 (was opened from the wrong branch and included stale commits).
🤖 Generated with Claude Code