Fix memory-safety and error-handling edge cases#1122
Open
stenslae wants to merge 1 commit into
Open
Conversation
stenslae
force-pushed
the
pr-memory-safety
branch
from
July 23, 2026 18:30
d3a7377 to
90fcb5c
Compare
stenslae
requested review from
wolfSSL-Fenrir-bot
and removed request for
wolfSSL-Fenrir-bot
July 23, 2026 18:59
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1122
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a potential buffer overflow in PrepareUserAuthRequestPassword() to check if adding the password length and overhead to payloadSz would exceed MAX_PACKET_SZ before actually modifying it. Modified wolfSSH_MakeMlDsaKey() to dynamically allocate the MlDsaKey structure on the heap rather than the stack when WOLFSSH_SMALL_STACK is defined. Added test coverage.