Bug Fixes: issues discovered during MC/DC coverage step 4 - #10973
Merged
Conversation
|
Contributor
|
Retest this please. (not clear what failed). |
philljj
self-requested a review
July 22, 2026 19:43
Contributor
|
Retest this please. windows test: |
SparkiDev
requested changes
Jul 24, 2026
Return early when inSz == 0, mirroring the other Ascon Update functions.
Initialize the mp_int temporaries as soon as they are allocated in wc_CompareDiffPQ(), _CheckProbablePrime() and wc_CheckProbablePrime_ex(), so the cleanup path handles them consistently in all cases.
Return 0 when all used digits are zero instead of scanning past them.
…stead Restore the original short-circuit XMALLOC chains and leave the zeroing to mp_init_multi(). On a partial allocation failure mp_init_multi() is skipped, so nothing is initialized: free whatever was allocated right there and NULL the pointers, so the shared cleanup at the end of the function never calls mp_clear()/mp_forcezero() on an allocated-but-uninitialized mp_int. No extra mp_init() calls, no XMEMSET, and the returned error codes are unchanged.
danielinux
force-pushed
the
fixes-mcdc-step4
branch
from
July 29, 2026 06:02
aaa59d9 to
94014ee
Compare
Member
Author
|
jenkins retest this please |
dgarske
approved these changes
Jul 30, 2026
SparkiDev
approved these changes
Jul 31, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10973
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
3x wolfcrypt bugfixes.
Testing
#10967
Checklist