Add indentation rule for array creation expressions - #139
Open
carestad wants to merge 4 commits into
Open
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @carestad on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
requested changes
Aug 3, 2026
MrSubidubi
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but needs some reformatting as noted in CI. Could you look into that, please?
Author
@MrSubidubi Sure thing! Should be updated now 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds indentation rules for PHP array creation expressions.
Pressing Enter after an opening
[orarray(left the new line at column 0.indents.scmonly matched nodes containing{/}, so neither array form was covered - both use brackets or parentheses.Before:
After:
Both short
[]and legacyarray()syntax are handled; in tree-sitter-php both produce an array_creation_expression` node, differing only in the closing delimiter.Note the rules are scoped to
array_creation_expressionrather than matching]or)generally, since]also closes array access ($foo['bar']).Tested locally on Zed v1.13.1 with a fresh profile.
Fixes #138