perf(array): move struct fields into slots#8958
Draft
joseph-isaacs wants to merge 4 commits into
Draft
Conversation
…-macro-design-pemah1 Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # vortex-array/src/arrays/masked/execute.rs # vortex-compressor/src/compressor/cascade.rs
Signed-off-by: "Joe Isaacs" <joe.isaacs@live.co.uk>
Signed-off-by: "Joe Isaacs" <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
agent/struct-owned-field-api
branch
from
July 24, 2026 16:24
408e2e4 to
95d9aad
Compare
joseph-isaacs
changed the base branch from
agent/struct-owned-field-api
to
develop
July 24, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make_struct_slotsconsumeVec<ArrayRef>StructSlotsWhy
ArraySlotsowns its children, so a borrowed&[ArrayRef]necessarily clones each handle when building the slots. The preceding API PR makes the field collection owned; this PR consumes that vector and moves its entries into slot storage, avoiding the per-fieldArrayRefclone/refcount increment.No field array buffers are copied.
Stack
Checks
RUSTC_WRAPPER= cargo check -p vortex-array --all-targetscargo clippy -p vortex-array --all-targets -- -D warnings(run on the combined stack)cargo +nightly fmt --all -- --checkgit diff --check